BIND 10 #2480: use real data sources in auth QueryTest
BIND 10 Development
do-not-reply at isc.org
Thu Jan 3 13:22:07 UTC 2013
#2480: use real data sources in auth QueryTest
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: b10-auth | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
I noticed two minor things. This comment in the generator script talks
about
various forms, but now there's only one.
{{{
This is a supplemental script to generate various forms of test data
from a unified source file.
}}}
Also, the `addRRsets` function does not (if I'm not mistaken) work twice
in a
row for in-memory. It'd remove the RR sets added by the first call during
the
second call. There should at least be a comment about it (as the two calls
are
not needed), or it should be solved.
It could probably be solved by getting its iterator, dumping the content
of the
in-memory to file, then append the RRsets to add and load that one. But
maybe
that's just needlessly complicated.
So, if you're going to add just the comment, I think I don't need to
review it
again.
--
Ticket URL: <http://bind10.isc.org/ticket/2480#comment:15>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list