BIND 10 #2480: use real data sources in auth QueryTest
BIND 10 Development
do-not-reply at isc.org
Thu Jan 3 19:59:06 UTC 2013
#2480: use real data sources in auth QueryTest
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: medium | Status:
Component: b10-auth | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 5 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:15 vorner]:
> I noticed two minor things. This comment in the generator script talks
about
> various forms, but now there's only one.
> {{{
> This is a supplemental script to generate various forms of test data
> from a unified source file.
> }}}
Oh, good catch, fixed.
> Also, the `addRRsets` function does not (if I'm not mistaken) work twice
in a
> row for in-memory. It'd remove the RR sets added by the first call
during the
> second call. There should at least be a comment about it (as the two
calls are
> not needed), or it should be solved.
Good point...
> It could probably be solved by getting its iterator, dumping the content
of the
> in-memory to file, then append the RRsets to add and load that one. But
maybe
> that's just needlessly complicated.
...yeah, I think it's okay with the restriction for now. I've added
comments, and also added explicit an ASSERT test to detect any
accidental duplicate call.
There's one additional missing EXTRA_DIST, so I've added it, too.
I believe all of these are trivial, so I've merged it to master, and
am now closing the ticket.
--
Ticket URL: <http://bind10.isc.org/ticket/2480#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list