BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText

BIND 10 Development do-not-reply at isc.org
Thu Jan 3 13:37:07 UTC 2013


#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20130108
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Is this explicit cast needed in any way? The types (`uint8_t` and
 `size_t`)
 should be auto-convertible. The cast makes me think there's something more
 complicated involved than just change of integer size.

 Replying to [comment:17 muks]:
 > On the datasrc test, the mistake I made was that I was directly writing
 the escaped values using the columns passed to the accessor.
 >
 > Maybe I'm missing seeing it, but there doesn't seem to be any API that
 accepts an `RRset` to write to the `records` table. So is such a datasrc
 test required if the test has to call `rrset.toText()` directly?
 > (Note that `toText()` is already tested for the various valid escape
 sequences in libdns++).

 Well, there's ‒ the zone updater (it's just one level higher than the
 accessor). You wouldn't write directly to the table, you'd add it to the
 zone,
 commit and read it again to see it gets out correctly.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list