BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText
BIND 10 Development
do-not-reply at isc.org
Fri Jan 4 13:26:30 UTC 2013
#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | vorner
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130108
Sub-Project: DNS | Resolution:
Estimated Difficulty: 3 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => vorner
Comment:
Hi Michal
Replying to [comment:18 vorner]:
> Is this explicit cast needed in any way? The types (`uint8_t` and
`size_t`)
> should be auto-convertible. The cast makes me think there's something
more
> complicated involved than just change of integer size.
This does not cause a compiler error or warning on my box.
But we've had warnings (and hence errors due to `-Werror`) before due to
such
type narrowing in BIND 10 code, which is why this was added. I think
explicit
casting requirement was introduced in a recent C++ and some
compilers/versions
cause a warning anyway (I think Visual C++ also warns).
See `XfroutClient::sendXfroutRequestInfo()` for sample code that caused
such a compiler warning before in the BIND 10 tree.
> Replying to [comment:17 muks]:
> Well, there's ‒ the zone updater (it's just one level higher than the
> accessor). You wouldn't write directly to the table, you'd add it to the
zone,
> commit and read it again to see it gets out correctly.
This is now implemented.
--
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list