BIND 10 #2535: handle escaped characters in TXTLikeImpl::toText
BIND 10 Development
do-not-reply at isc.org
Fri Jan 4 13:59:22 UTC 2013
#2535: handle escaped characters in TXTLikeImpl::toText
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | reviewing
Component: libdns++ | Milestone:
Keywords: | Sprint-20130108
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 3 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
Replying to [comment:19 muks]:
> But we've had warnings (and hence errors due to `-Werror`) before due to
such
> type narrowing in BIND 10 code, which is why this was added. I think
explicit
> casting requirement was introduced in a recent C++ and some
compilers/versions
> cause a warning anyway (I think Visual C++ also warns).
I'd be very surprised if the cast would be required in this case, as many
assignments to `uint8_t` would require one, because all integer
arithmetics is
AFAIK done on `int`-sized or bigger integers. But I don't mind it, so
let's
leave it there.
The code looks OK, so please merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2535#comment:20>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list