BIND 10 #2572: extend MasterLexer to provide current/total bytes of source(s)

BIND 10 Development do-not-reply at isc.org
Fri Jan 11 09:58:36 UTC 2013


#2572: extend MasterLexer to provide current/total bytes of source(s)
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Replying to [comment:7 jinmei]:
 >
 > error handling that follow).  Unfortunately I found it difficult to
 > test it in the unittest framework (we'd need another process or create
 > a unix domain socket or something, which seemed overkilling for this
 > purpose), so I only emulated the case by tweaking error bits in
 > istream.
 >

 I believe we could use std::cin as an input stream to push in the test (as
 long as we make sure we don't actually try to read from it), but I have no
 strong objection against the current approach.

 >
 > Oops, (I believe) that was simply a typo and should have been
 > "popped".  Fixed.

 Ah, that does explain a lot :) Perhaps we can even add 'in that case the
 total source size would also decrease', but no strong opinion.

 Whether or not you decide to change these two small points, I think it can
 be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2572#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list