BIND 10 #2572: extend MasterLexer to provide current/total bytes of source(s)

[BIND 10 Development]

#2572: extend MasterLexer to provide current/total bytes of source(s)
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:9 jelte]:

 > > error handling that follow).  Unfortunately I found it difficult to
 > > test it in the unittest framework (we'd need another process or create
 > > a unix domain socket or something, which seemed overkilling for this
 > > purpose), so I only emulated the case by tweaking error bits in
 > > istream.
 >
 > I believe we could use std::cin as an input stream to push in the test
 (as long as we make sure we don't actually try to read from it), but I
 have no strong objection against the current approach.

 Actually, I tried it in a pre-review version and found it (just
 passing std::cin) didn't work.  In that case getting the size
 succeeded with the result of 0.  We'd need a trickier set up like
 associating std::cin with another process via pipe, but I didn't go
 that far.

 > > Oops, (I believe) that was simply a typo and should have been
 > > "popped".  Fixed.
 >
 > Ah, that does explain a lot :) Perhaps we can even add 'in that case the
 total source size would also decrease', but no strong opinion.

 Okay, I've updated the doc mentioning the total size (in a different
 phrase).

 > Whether or not you decide to change these two small points, I think it
 can be merged.

 Thanks, now merge done, closing ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2572#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development