BIND 10 #2573: extend MasterLoader and ZoneLoader to return additional states including # of loaded RRs
BIND 10 Development
do-not-reply at isc.org
Mon Jan 14 11:26:50 UTC 2013
#2573: extend MasterLoader and ZoneLoader to return additional states including #
of loaded RRs
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: task | jinmei
Priority: medium | Status:
Component: libdns++ | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130122
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| loadzone-ng
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
I agree it's mostly straight-forward. But I'd propose one change.
Currently, the ZoneLoader has two methods (`getSize()` and
`getPosition()`)
which both return some abstract number without meaning (at least according
to
the documentation) which are useful only to get the progress estimate.
Then
each caller needs to relate them and take care, because the `getSize()`
can
return unknown size (in which case it shouldn't attempt to guess the
progress)
or 0, in which case it shouldn't divide by it.
Would it be more reasonable to have only one method, doing this guesswork
internally and returning the progress, let's say as double between 0 and 1
or
something like that?
If you don't agree, please at least warn that `getSize()` can return 0, so
people should be careful when dividing by it.
--
Ticket URL: <http://bind10.isc.org/ticket/2573#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list