BIND 10 #2573: extend MasterLoader and ZoneLoader to return additional states including # of loaded RRs

[BIND 10 Development]

#2573: extend MasterLoader and ZoneLoader to return additional states including #
of loaded RRs
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:5 vorner]:

 > I agree it's mostly straight-forward. But I'd propose one change.
 >
 > Currently, the ZoneLoader has two methods (`getSize()` and
 `getPosition()`)
 > which both return some abstract number without meaning (at least
 according to
 > the documentation) which are useful only to get the progress estimate.
 Then
 > each caller needs to relate them and take care, because the `getSize()`
 can
 > return unknown size (in which case it shouldn't attempt to guess the
 progress)
 > or 0, in which case it shouldn't divide by it.
 >
 > Would it be more reasonable to have only one method, doing this
 guesswork
 > internally and returning the progress, let's say as double between 0 and
 1 or
 > something like that?

 Actually, I wondered the same thing, so I made that change.
 getPosition and getSize were now deprecated and removed from
 `ZoneLoader`.  I chose to return an integer between 0 and 100 instead
 of floating points as integers are generally easier to use and I didn't
 see the need for higher granularity than that.  But that's not a
 strong opinion.

 I made one additional cleanup at the last commit (see the log), which
 may be debatable.  If so, I'm okay with skipping that part for this
 task.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2573#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development