BIND 10 #2438: python interface for RRsetCollection

[BIND 10 Development]

#2438: python interface for RRsetCollection
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jinmei


Comment:

 Hello

 First of, it doesn't pass distcheck here. The `datasrc/rrset_collection.h`
 is not included in the `_SOURCES`. I also noticed neither is the
 corresponding .cc file (which is probably needed, so the linker wouldn't
 compile). But when I tried adding both, the .cc file doesn't compile. I
 didn't notice this branch would create that file, are you using some code
 that is not in master yet?
 {{{
 ../../../../src/lib/datasrc/database.cc:35:38: fatal error:
 datasrc/rrset_collection.h: No such file or directory
 compilation terminated.
 }}}

 Then I see mostly minor documentation/comment problems:

 The relation with derived class and find and cppobj is completely unclear
 here. There should be a comment, since it looks like this is unrelated.
 {{{#!c++
     if (self->cppobj == NULL) {
         PyErr_Format(PyExc_TypeError, "find() is not implemented in the "
                      "derived RRsetCollection class");
         return (NULL);
     }
 }}}

 Is this really true for python? It seems the constructor does exist, it
 just always throws:
 {{{
 This base class cannot be directly instantiated, so no constructor is\n\
 defined.\n\
 }}}

 This bit of documentation is confused about `input` vs. `input_stream`.
 Also, is the type really called `byte` (singular form)?
 {{{
 RRsetCollection(input_stream, origin, rrclass)\n\
 \n\
     Constructor.\n\
 \n\
     This constructor is similar to the previous one, but instead of\n\
     taking a filename to load a zone from, it takes a byte object,\n\
     representing the zone contents in text.\n\
     The constructor throws IscException if there is an error\n\
     during loading.\n\
 \n\
     Parameters:\n\
       input      (byte) Textual representation of the zone.\n\
       origin     (isc.dns.Name) The zone origin.\n\
       rrclass    (isc.dns.RRClass) The zone class.\n\
 \n\
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2438#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development