BIND 10 #2438: python interface for RRsetCollection

[BIND 10 Development]

#2438: python interface for RRsetCollection
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  jinmei
            Priority:  medium        |                       Status:
           Component:  libdns++      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:7 vorner]:

 > First of, it doesn't pass distcheck here. The
 `datasrc/rrset_collection.h` is not included in the `_SOURCES`. I also
 noticed neither is the corresponding .cc file (which is probably needed,
 so the linker wouldn't compile). But when I tried adding both, the .cc
 file doesn't compile. I didn't notice this branch would create that file,
 are you using some code that is not in master yet?
 > {{{
 > ../../../../src/lib/datasrc/database.cc:35:38: fatal error:
 datasrc/rrset_collection.h: No such file or directory
 > compilation terminated.
 > }}}

 Ah, good catch.  It seems to be because I merged two incomplete
 branches.  I removed now-unnecessary files and includes and it should
 now be fixed.

 > Then I see mostly minor documentation/comment problems:

 I tried to address these points in the updated doc.

 And, finally, I found distcheck still fails due to the need for
 implicitly importing isc.dns (pydnspp) Python module.  I've added
 workaround at commit 003f49d (I believe #2148 gives a cleaner
 solution, but it should be left to that ticket).  I confirmed
 distcheck now passed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2438#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development