BIND 10 #2499: basic post-load validation for in-memory data source

[BIND 10 Development]

#2499: basic post-load validation for in-memory data source
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130122
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:7 vorner]:
 > Hello
 >
 > Replying to [comment:5 muks]:
 > > Note that a single test `ZoneLoaderTest.copyCheck` has been disabled
 as `prepareSource()` in that test-suite does not contain a correct
 implementation. Not sure if we should fix this as part of the current bug.
 Please let me know in the review comments.
 >
 > Yes, please do.

 Done. :)

 > Also, the rrset-collection.zone file, isn't it copy of something else,
 used to test the loader? Does it really have to contain all the strange
 things like whitespace at the beginning of line, followed by comment or
 oddly-encoded names? And, if you insist it should be the same file, should
 we use a symlink instead?

 The contents of `rrset-collection.zone` have been updated now.

 > And, I think there should be a test checking it throws on some invalid
 zones.

 I am not clearly following this. If it means that
 `ZoneLoaderTest.copyCheck` should be re-enabled, it is now.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2499#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development