BIND 10 #2499: basic post-load validation for in-memory data source

[BIND 10 Development]

#2499: basic post-load validation for in-memory data source
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  data source   |                    Milestone:
            Keywords:                |  Sprint-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  4             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |  loadzone-ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 Replying to [comment:13 muks]:
 > > Yes, please do.
 >
 > Done. :)

 Some questions to the code:
  * Why does the Finder accept the origin as parameter, while the Iterator
 has one hardcoded? Shouldn't it be unified?
  * I don't think the whole TODO in `prepareSource` has been taken care of.
 Actually, it should have been taken care as a result of #2470, which made
 it not true, now it uses the same code, so it doesn't cross-check the
 implementation. I don't know if that's OK (but it wouldn't be in the scope
 of this ticket, I just ask for having a TODO with regard to it).
  * I don't think it is a good idea to take the test out of the text
 fixture. Not because it would need some variables from it, but having the
 related tests together makes it easier to filter them using
 `GTEST_FILTER`.

 > > And, I think there should be a test checking it throws on some invalid
 zones.
 >
 > I am not clearly following this. If it means that
 `ZoneLoaderTest.copyCheck` should be re-enabled, it is now.

 No, I meant that more zones are rejected now, during the load. A new test
 for the in-memory loader should be added and see that there's a zone that
 throws the new `ZoneValidationError` exception. Maybe I looked wrong, but
 I didn't see such test.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2499#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development