BIND 10 #2591: DHCPv4 server to include configured options in its responses to a client

[BIND 10 Development]

#2591: DHCPv4 server to include configured options in its responses to a client
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  task          |  marcin
            Priority:  high          |                       Status:
           Component:  dhcp4         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130122
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => marcin


Comment:

 Review of all changes present on 933430e40bb35135d741df5b9c8b944c5bf9be83
 '''src/bin/dhcp4/dhcp4_srv.cc'''
 Please remove HARDCODED_DNS_SERVER, HARDCODED_DOMAIN_NAME.
 Please update assignLease method to not use HARDCODED_GATEWAY, but the
 actual DHO_ROUTERS option.

 '''appendRequestedOptions''':
 The code aborts if there was nothing requested (no PRL). Wouldn't it be
 more helpful to assign some basic (netmask, gateway, domain, dns) options
 to buggy clients that didn't send PRL? This is an honest question. It's a
 tradeoff between strict RFC compliance and support for clueless/buggy
 clients.

 {{{
 if (desc.option) {
     msg->addOption(desc.option);
 }
 }}}
 Is it even possible to have a OptionDescriptor without actual option
 defined?

 '''appendDefaultOptions'''
 I think this method should insert all options that have persistent flag
 set.

 '''src/bin/dhcp4/tests/dhcp4_srv_unittest.cc'''
 "Paramter" => "Parameter" in addPrlOption doxygen comment.
 "This function PRL option comprising the following option codes:" - this
 doesn't have to be wrapped and will fit into a single line that is less
 than 80 columns long.

 I would prefer if OptionIntArray template class had method addCode() or
 addValue(). It would be easier to manipulate and more efficient (no need
 to create temporary vector that is later copied).


 Please update ChangeLog.
 Please update BIND10 Guide: give examples on how to define options and
 remove HARDCODED_* list in section 16.2.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2591#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development