BIND 10 #2591: DHCPv4 server to include configured options in its responses to a client

[BIND 10 Development]

#2591: DHCPv4 server to include configured options in its responses to a client
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:  tomek
                Type:  task          |                       Status:
            Priority:  high          |  reviewing
           Component:  dhcp4         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130122
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => tomek


Comment:

 Replying to [comment:4 tomek]:
 > Review of all changes present on
 933430e40bb35135d741df5b9c8b944c5bf9be83
 > '''src/bin/dhcp4/dhcp4_srv.cc'''
 > Please remove HARDCODED_DNS_SERVER, HARDCODED_DOMAIN_NAME.
 > Please update assignLease method to not use HARDCODED_GATEWAY, but the
 actual DHO_ROUTERS option.

 Updated.

 >
 > '''appendRequestedOptions''':
 > The code aborts if there was nothing requested (no PRL). Wouldn't it be
 more helpful to assign some basic (netmask, gateway, domain, dns) options
 to buggy clients that didn't send PRL? This is an honest question. It's a
 tradeoff between strict RFC compliance and support for clueless/buggy
 clients.

 I added the function that appends basic options if they are not requested
 but configured.

 >
 > {{{
 > if (desc.option) {
 >     msg->addOption(desc.option);
 > }
 > }}}
 > Is it even possible to have a OptionDescriptor without actual option
 defined?

 The NULL pointer in option descriptor means that the option has not been
 configured.

 >
 > '''appendDefaultOptions'''
 > I think this method should insert all options that have persistent flag
 set.

 The persistency flag is not used/configured yet.

 >
 > '''src/bin/dhcp4/tests/dhcp4_srv_unittest.cc'''
 > "Paramter" => "Parameter" in addPrlOption doxygen comment.
 > "This function PRL option comprising the following option codes:" - this
 doesn't have to be wrapped and will fit into a single line that is less
 than 80 columns long.

 Fixed.

 >
 > I would prefer if OptionIntArray template class had method addCode() or
 addValue(). It would be easier to manipulate and more efficient (no need
 to create temporary vector that is later copied).

 I added a new function and the unit test.

 >
 >
 > Please update ChangeLog.
 > Please update BIND10 Guide: give examples on how to define options and
 remove HARDCODED_* list in section 16.2.
 >

-- 
Ticket URL: <http://bind10.isc.org/ticket/2591#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development