BIND 10 #2989: Python notify_out module should use general datasource configuration, not Auth/database_file
BIND 10 Development
do-not-reply at isc.org
Thu Jul 25 11:45:09 UTC 2013
#2989: Python notify_out module should use general datasource configuration, not
Auth/database_file
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | UnAssigned
Priority: medium | Status:
Component: xfrout | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130806
Sub-Project: DNS | Resolution:
Estimated Difficulty: 4 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => UnAssigned
* status: accepted => reviewing
Comment:
Hello
It is ready for review. Some things worth a note:
* The old version of the Notify module populated a dictionary of zone
names in memory in startup. This is harder to do with using the client
lists. But is is also wrong, as the list will get outdated. Currently, I
start with an empty list and load the things on-demand. But I don't clean
them up once they are no longer used, as it is not needed for this task.
OK to leave for a clean-up ticket?
* I did not follow the ticket description to letter. To do so, I'd need
to create another connection to the CC, which seems like too much work and
too ugly. Instead, I provide a method that can be called from other thread
that'll push a new configuration into the notify object.
* The xfrout still uses the old way and old configuration. For now, I
create the notify with constructed configuration for the set database
file. Updates are not propagated. I expect #2965 will do that, it'd be
just calling the correct method when the update comes, but it needs non-
trivial changes to the code (the changes that look like they belong to
#2965).
No changelog, since there should be no user-visible change for now.
--
Ticket URL: <https://bind10.isc.org/ticket/2989#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list