BIND 10 #2987: Investigate valgrind issues after merge of #2902 (Direct DHCPv4 traffic)

[BIND 10 Development]

#2987: Investigate valgrind issues after merge of #2902 (Direct DHCPv4 traffic)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  libdhcp       |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130606
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => marcin


Comment:

 Reviewed commit 77def77e9ab95155f91dcd9506de0f8ea1001d8a

 '''src/lib/dhcp/tests/pkt_filter_inet_unittest.cc'''[[BR]]
 '''src/lib/dhcp/tests/pkt_filter_lpf_unittest.cc'''[[BR]]
 In the test class in both these files, socket_ is initialised to zero then
 closed unconditionally at the end of the test.  As 0 is stdin, I guess
 there could be an issue if a future test made use of that.  It would be
 safer to initialise socket_ to an invalid descriptor number (e.g. -1) and
 only close it in the destructor if the value is greater than or equal to
 0.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2987#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development