BIND 10 #2987: Investigate valgrind issues after merge of #2902 (Direct DHCPv4 traffic)

[BIND 10 Development]

#2987: Investigate valgrind issues after merge of #2902 (Direct DHCPv4 traffic)
-------------------------------------+-------------------------------------
            Reporter:  marcin        |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  libdhcp       |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130606
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:
                                     |  Medium
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * owner:  marcin => stephen


Comment:

 Even if the socket descriptor 0 points to the stdin, the close() function
 will return -1 and set errno to the actual error code, in the worst case.
 The returned value is ignored in the destructor so I didn't see any issue
 here.

 On the other hand, checking for the negative value helps to avoid
 unnecessary calls to close() and has no drawbacks. So, I made a change as
 suggested.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2987#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development