BIND 10 #2978: Use DHCPDDNS_XXX as prefix for D2 log messages.

BIND 10 Development do-not-reply at isc.org
Tue Jun 11 14:17:45 UTC 2013


#2978: Use DHCPDDNS_XXX as prefix for D2 log messages.
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp          |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130620
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tmark


Comment:

 Reviewed commit 4ee45a9b6fe66798c2aa22ecfc6b9522b9ba8d37

 '''src/bin/d2/d2_controller.cc'''[[BR]]
 d2_app_name_: it's not really usual to use an initial capital letter in
 dhcp or dns - they are generally written as all capitals or all lower-
 case.  In this instance, upper-case may be better (DHCP-DDNS) or expand
 it: "DHCP DDNS client"

 '''src/bin/d2/d2_log.cc'''[[BR]]
 Not sure about "dctl" as the string used to identify the logger (although
 dctl_logger is OK as the name of the variable in the code).  The string is
 used by the user in the configuration to change the logging for that
 module, so names like dhcpdns or dhcpddns are better.

 This probably requires a !ChangeLog entry.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2978#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list