BIND 10 #2978: Use DHCPDDNS_XXX as prefix for D2 log messages.

[BIND 10 Development]

#2978: Use DHCPDDNS_XXX as prefix for D2 log messages.
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20130620
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => stephen


Comment:

 > Reviewed commit 4ee45a9b6fe66798c2aa22ecfc6b9522b9ba8d37
 >
 > '''src/bin/d2/d2_controller.cc'''[[BR]]
 > d2_app_name_: it's not really usual to use an initial capital letter in
 dhcp or dns - they are generally written as all capitals or all lower-
 case.  In this i
 nstance, upper-case may be better (DHCP-DDNS) or expand it: "DHCP DDNS
 client"
 >

 I have upper-cased it.


 ~~
 > '''src/bin/d2/d2_log.cc'''[[BR]]
 > Not sure about "dctl" as the string used to identify the logger
 (although dctl_logger is OK as the name of the variable in the code).  The
 string is used by the user in the configuration to change the logging for
 that module, so names like dhcpdns or dhcpddns are better.
 >

 I have changed it to dhcpddns.


 > This probably requires a !ChangeLog entry.

 I'm guessing this is to announce the existence of a new logger?

 6xx     [func]      tmark
     Logger name for DHCP-DDNS has been changed from "d2_logger" to
 "dhcpddns".
     In addition, its log messages now use two suffixes, DCTL_ for logs the
     emanate from the underlying base classes, and DHCP_DDNS_ for logs
 which
     emanate from DHCP-DDNS specific code

-- 
Ticket URL: <http://bind10.isc.org/ticket/2978#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development