BIND 10 #2853: Python wrapper of data source extensions

[BIND 10 Development]

#2853: Python wrapper of data source extensions
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  data source   |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130625
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |  shared memory data source
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => vorner


Comment:

 Hi Michal

 Replying to [comment:32 vorner]:
 > Hello
 >
 > I discovered two things.
 >
 > The docstring of the newly added test seems to be a copy paste. It
 > speaks about not being reset yet. But as the cache is not enabled, it
 > does not need to be reset AFAIK.

 Oops! Fixed.

 > The indentation seems wrong here:
 > {{{
 > +            } else {
 > +                 Py_INCREF(Py_None);
 > +                segment_type.reset(Py_None);
 >              }
 > }}}

 Fixed. I wrapped some other lines too.

 > Also, there is probably wrongly handled file in some makefile, since
 distcheck fairs:
 > {{{
 > ======================================================================
 > ERROR: test_get_status_unused (__main__.ClientListTest)
 > ----------------------------------------------------------------------
 > Traceback (most recent call last):
 >   File
 "/tmp/bind10/bind10-1/bind10-20130529/_build/../src/lib/python/isc/datasrc/tests/clientlist_test.py",
 line 273, in test_get_status_unused
 >     }]''', True)
 > isc.datasrc.Error: Unknown uncaught exception from sqlite3
 createInstance: Error creating SQLite3 datasource: Cannot open SQLite
 database file:
 /tmp/bind10/bind10-1/bind10-20130529/_build/../src/lib/testutils/testdata/example.org.sqlite3
 >
 > ----------------------------------------------------------------------
 > }}}

 You're right. `make check` had passed for me because I think some other
 test had setup that data. I have updated where the test data is used
 from now. `make distcheck` passes.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2853#comment:33>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development