BIND 10 #2853: Python wrapper of data source extensions
BIND 10 Development
do-not-reply at isc.org
Mon Jun 17 08:38:31 UTC 2013
#2853: Python wrapper of data source extensions
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | reviewing
Component: data source | Milestone:
Keywords: | Sprint-20130625
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 5 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| shared memory data source
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => muks
Comment:
Hello
I discovered two things.
The docstring of the newly added test seems to be a copy paste. It speaks
about not being reset yet. But as the cache is not enabled, it does not
need to be reset AFAIK.
The indentation seems wrong here:
{{{
+ } else {
+ Py_INCREF(Py_None);
+ segment_type.reset(Py_None);
}
}}}
Also, there is probably wrongly handled file in some makefile, since
distcheck fairs:
{{{
======================================================================
ERROR: test_get_status_unused (__main__.ClientListTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/tmp/bind10/bind10-1/bind10-20130529/_build/../src/lib/python/isc/datasrc/tests/clientlist_test.py",
line 273, in test_get_status_unused
}]''', True)
isc.datasrc.Error: Unknown uncaught exception from sqlite3 createInstance:
Error creating SQLite3 datasource: Cannot open SQLite database file:
/tmp/bind10/bind10-1/bind10-20130529/_build/../src/lib/testutils/testdata/example.org.sqlite3
----------------------------------------------------------------------
}}}
--
Ticket URL: <http://bind10.isc.org/ticket/2853#comment:32>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list