BIND 10 #2764: base_xx wrapper doesn't compile with Boost 1.53
BIND 10 Development
do-not-reply at isc.org
Wed Mar 6 11:07:40 UTC 2013
#2764: base_xx wrapper doesn't compile with Boost 1.53
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner:
Type: defect | jinmei
Priority: high | Status:
Component: build system | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-20130319
Sub-Project: Core | Resolution:
Estimated Difficulty: 2 | CVSS Scoring:
Total Hours: 0.49 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
* totalhours: 0 => 0.49
Comment:
I noticed only one minor point:
{{{#!c++
if (((char_count * BitsPerChunk) & 7) != 0) {
}}}
I think it may be easier to read with % 8 instead of & 7, especially when
looking at the comment above. Note that any compiler will just change that
to the mask internally instead of using division instructions.
After that, I believe it can be merged.
--
Ticket URL: <http://bind10.isc.org/ticket/2764#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list