BIND 10 #2764: base_xx wrapper doesn't compile with Boost 1.53

[BIND 10 Development]

#2764: base_xx wrapper doesn't compile with Boost 1.53
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:
                Type:  defect        |  jinmei
            Priority:  high          |                       Status:
           Component:  build system  |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130319
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0.49          |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Thanks for the review.

 Replying to [comment:8 vorner]:
 > I noticed only one minor point:
 >
 > {{{#!c++
 > if (((char_count * BitsPerChunk) & 7) != 0) {
 > }}}
 >
 > I think it may be easier to read with % 8 instead of & 7, especially
 when looking at the comment above. Note that any compiler will just change
 that to the mask internally instead of using division instructions.

 Hmm, I'm not so sure about "any compiler" - I'm afraid the level of
 arithmetic reduction can be quite compiler dependent except for very
 trivial ones.  But from quick experiments it at least seems to be the
 case for clang++ and g++, so I made the change.  BaseX decoding is
 relatively expensive anyway, so even if it's not optimized it's
 probably not a big deal.

 > After that, I believe it can be merged.

 I found one other point of cleanup, but I believe it's trivial, so
 I've merge the branch with that cleanup.  Now closing the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2764#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development