BIND 10 #2821: MySQLLeaseManager does not close db if constructor fails

[BIND 10 Development]

#2821: MySQLLeaseManager does not close db if constructor fails
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:  jelte
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  Unclassified  |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130328
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jelte


Comment:

 Reviewed commit e58c2fd32cb85d37cd96ff8bb6a7cdf0f653a5a1

 I've added a set of comments to the !MySqlHolder class and pushed the
 changes.

 One minor thing: is there any reason that the call to mysql_library_end()
 can't go in the !MySqlHolder destructor?  mysql_lease_mgr.* are the only
 files that refer to !MySql, so it seems logical that all !MySql-related
 stuff should go there.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2821#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development