BIND 10 #2821: MySQLLeaseManager does not close db if constructor fails
BIND 10 Development
do-not-reply at isc.org
Fri Mar 8 11:01:49 UTC 2013
#2821: MySQLLeaseManager does not close db if constructor fails
-------------------------------------+-------------------------------------
Reporter: jelte | Owner:
Type: defect | stephen
Priority: medium | Status:
Component: Unclassified | reviewing
Keywords: | Milestone:
Sensitive: 0 | Sprint-DHCP-20130328
Sub-Project: DNS | Resolution:
Estimated Difficulty: 0 | CVSS Scoring:
Total Hours: 0 | Defect Severity: N/A
| Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => stephen
Comment:
Replying to [comment:7 stephen]:
>
> I've added a set of comments to the !MySqlHolder class and pushed the
changes.
>
thanks!
> One minor thing: is there any reason that the call to
mysql_library_end() can't go in the !MySqlHolder destructor?
mysql_lease_mgr.* are the only files that refer to !MySql, so it seems
logical that all !MySql-related stuff should go there.
ok, done.
updated the create and destroy code in the unit tests to use the holder as
well
--
Ticket URL: <http://bind10.isc.org/ticket/2821#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list