BIND 10 #2710: b10-cmdctl needs restart when adding users

[BIND 10 Development]

#2710: b10-cmdctl needs restart when adding users
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:  jelte
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  bind-ctl      |                    Milestone:
            Keywords:                |  Sprint-20130319
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 The method looks good enough, but there are few minor nits:

 Why is the file initialized for None, but then, if the file does not
 exist, it is still set to the path of the file that does not exist?

 Why not output all the lines at once here? Something like joining them
 with "\n" and writing?
 {{{#!python
     def __enter__(self):
         with open(self.__path, 'w') as f:
             for line in self.__contents:
                 f.write(line)
 }}}

 Is the second assert here of any use? If the dict is empty, then 'root'
 definitely is not in it.
 {{{#!python
         self.assertEqual(0, len(self.server._user_infos))
         self.assertFalse('root' in self.server._user_infos)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/2710#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development