BIND 10 #2710: b10-cmdctl needs restart when adding users

[BIND 10 Development]

#2710: b10-cmdctl needs restart when adding users
-------------------------------------+-------------------------------------
            Reporter:  jelte         |                        Owner:
                Type:  defect        |  vorner
            Priority:  medium        |                       Status:
           Component:  bind-ctl      |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130319
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  3             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:9 vorner]:
 > Hello
 >
 > The method looks good enough, but there are few minor nits:
 >
 > Why is the file initialized for None, but then, if the file does not
 exist, it is still set to the path of the file that does not exist?
 >

 in the (probably nonexistent, due to config checks) case that it is
 changed to something that does not exist; however it should indeed just be
 reset to None in that case. Changed.

 > Why not output all the lines at once here? Something like joining them
 with "\n" and writing?
 > {{{#!python
 >     def __enter__(self):
 >         with open(self.__path, 'w') as f:
 >             for line in self.__contents:
 >                 f.write(line)
 > }}}
 >

 OK

 > Is the second assert here of any use? If the dict is empty, then 'root'
 definitely is not in it.
 > {{{#!python
 >         self.assertEqual(0, len(self.server._user_infos))
 >         self.assertFalse('root' in self.server._user_infos)
 > }}}

 heh :) no, indeed. Removed :)

-- 
Ticket URL: <http://bind10.isc.org/ticket/2710#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development