BIND 10 #1927: Msgq tests: normal operation

BIND 10 Development do-not-reply at isc.org
Wed Mar 13 14:38:47 UTC 2013


#1927: Msgq tests: normal operation
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:  jelte
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  msgq          |                    Milestone:
            Keywords:                |  Sprint-20130319
           Sensitive:  0             |                   Resolution:
         Sub-Project:  Core          |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:  msgq-
                                     |  ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Hello

 Replying to [comment:9 jelte]:
 > - could the sleep() in test_send_group() be done by another call to
 !__barrier()? I guess there would still be some theoretical scenarios that
 would not be caught, but if this is possible it seems slightly more
 reliable

 Indeed it could. The sleep was there before I discovered I need the
 barrier and wrote it and it didn't occur to me then.

 > - is the addition of resetUnitTestRootLogger in msgq itself necessary?
 It is normally only used in actual unit tests, and this changes default
 behaviour... I didn't notice any difference from it when actually running
 the tests, but if there is, it seems better to let the tests capture any
 output

 That's my fault. I added it to see verbose debug output from msgq during
 the tests and forgot to remove it afterwards. It does not belong there, of
 course.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1927#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list