BIND 10 #1927: Msgq tests: normal operation

BIND 10 Development do-not-reply at isc.org
Wed Mar 13 11:28:13 UTC 2013


#1927: Msgq tests: normal operation
-------------------------------------+-------------------------------------
            Reporter:  vorner        |                        Owner:
                Type:  task          |  vorner
            Priority:  medium        |                       Status:
           Component:  msgq          |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20130319
         Sub-Project:  Core          |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:  msgq-
                                     |  ng
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  UnAssigned => vorner


Comment:

 That looks ok; two comments:

 - could the sleep() in test_send_group() be done by another call to
 !__barrier()? I guess there would still be some theoretical scenarios that
 would not be caught, but if this is possible it seems slightly more
 reliable
 - is the addition of resetUnitTestRootLogger in msgq itself necessary? It
 is normally only used in actual unit tests, and this changes default
 behaviour... I didn't notice any difference from it when actually running
 the tests, but if there is, it seems better to let the tests capture any
 output

-- 
Ticket URL: <http://bind10.isc.org/ticket/1927#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list