BIND 10 #3119: [kean] botan present but not usable

[BIND 10 Development]

#3119: [kean] botan present but not usable
-------------------------------------+-------------------------------------
            Reporter:  wlodekwencel  |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  Unclassified  |  reviewing
            Keywords:  botan         |                    Milestone:
           Sensitive:  0             |  Sprint-20131015
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  2             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => stephen


Comment:

 I think the issue is how you did the test. #error is treated differently
 to other compilation errors. For example, I changed botan/init.h, which is
 included early on by botan/botan.h and changed the spelling of
 "deinitialize" to "deinitialise" to introduce an actual compilation error.
 I then get this:
 {{{
 configure: WARNING: botan/botan.h: present but cannot be compiled
 configure: WARNING: botan/botan.h:     check for missing prerequisite
 headers?
 configure: WARNING: botan/botan.h: see the Autoconf documentation
 configure: WARNING: botan/botan.h:     section "Present But Cannot Be
 Compiled"
 configure: WARNING: botan/botan.h: proceeding with the compiler's result
 configure: WARNING:     ## --------------------------------- ##
 configure: WARNING:     ## Report this to bind10-dev at isc.org ##
 configure: WARNING:     ## --------------------------------- ##
 checking for botan/botan.h... no
 configure: error:
 botan/botan.h was found but is unusable. The most common cause of this
 problem
 is attempting to use an updated C++ compiler with older C++ libraries,
 such as
 the version of Botan that comes with your distribution. If you have
 updated
 your C++ compiler we highly recommend that you use support libraries such
 as
 Boost and Botan that were compiled with the same compiler version.
 }}}

 This is a more realistic way of doing the test because it is designed to
 check for compilation errors from older buggy versions of the header file.
 #error causes the pre-processor to fail as well and that autoconf
 interprets as "the file does not exist" (which is an autoconf issue and
 not one I can code around with standard autoconf macros). The whole point
 of the change is to catch the case where the pre-processing passes (i.e
 file is deemed to exist) but compilation fails (header and compiler out of
 date WRT each other).

 I will however add a comment about the use of $ac_header_preproc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3119#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development