BIND 10 #3119: [kean] botan present but not usable

[BIND 10 Development]

#3119: [kean] botan present but not usable
-------------------------------------+-------------------------------------
            Reporter:  wlodekwencel  |                        Owner:  kean
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  Unclassified  |                    Milestone:
            Keywords:  botan         |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  2             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => kean


Comment:

 Reviewed commit 61f52a04ef4df1c8ba17ebf75baaa25e88b90342.

 > I think the issue is how you did the test. #error is treated differently
 to other compilation errors.
 Intriguing.  I repeated the test with a language error in the file and got
 the same result as you, so the change works. Three minor issues:
 * The comments about ac_header_preproc are preceded by "dnl", all other
 comments in the file are preceded by "#".  Changing "dnl" to "#" preserves
 consistency.
 * s/header no existing/header not existing/

 ... and one I missed from last time

 * Can the body (but not the error text) of the AC_CHECK_HEADERS "if-false"
 block be indented, so keeping with the style of other multi-line macros
 (e.g. see the AC_LINK_IFELSE block immediately following the changes)?

 After these modifications, please merge.  I do not need to see this again.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3119#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development