BIND 10 #3152: PD: Prefix assignment in DHCPv6 server (solicit, request)

[BIND 10 Development]

#3152: PD: Prefix assignment in DHCPv6 server (solicit, request)
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp6         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20131016
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => tomek


Comment:

 Reviewed commit 0d5c7903522b79906cb0335006d678911af1eee8

 I've made minor changes to wording and spacing in some files and pushed
 the change to the repository.

 '''src/bin/dhcp6/dhcp6_srv.cc'''[[BR]]
 Dhcpv6Srv::assignIA_PD: setting fake_allocation is more simply done by:
 {{{
 bool fake_allocation = (query->getType() == DHCPV6_SOLICIT);
 }}}

 As ia_rsp is initialized in the same way if the subnet is present or not
 (with an empty IA_PD option), the initialization could be done once, at
 the head of the method (before the subnet is checked).

 '''src/lib/dhcpsrv/tests/test_libraries.h'''[[BR]]
 This is created from the test_libraries.h.in file when the code is built.
 I don't think it should be in the git repository. (Admittedly I don't
 think its addition was part of the ticket.)

 (None of these suggested changes is mandatory.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/3152#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development