BIND 10 #3152: PD: Prefix assignment in DHCPv6 server (solicit, request)

[BIND 10 Development]

#3152: PD: Prefix assignment in DHCPv6 server (solicit, request)
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:
                Type:  enhancement   |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp6         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => stephen


Comment:

 Replying to [comment:6 stephen]:
 > Reviewed commit 0d5c7903522b79906cb0335006d678911af1eee8
 >
 > I've made minor changes to wording and spacing in some files and pushed
 the change to the repository.
 Thank you.

 > '''src/bin/dhcp6/dhcp6_srv.cc'''[[BR]]
 > Dhcpv6Srv::assignIA_PD: setting fake_allocation is more simply done by:
 > {{{
 > bool fake_allocation = (query->getType() == DHCPV6_SOLICIT);
 > }}}
 Updated. The code will eventually be expanded a bit when we start
 supporting rapid-commit, but until then let's keep things simple.

 > As ia_rsp is initialized in the same way if the subnet is present or not
 (with an empty IA_PD option), the initialization could be done once, at
 the head of the method (before the subnet is checked).
 Done.

 > '''src/lib/dhcpsrv/tests/test_libraries.h'''[[BR]]
 > This is created from the test_libraries.h.in file when the code is
 built.  I don't think it should be in the git repository. (Admittedly I
 don't think its addition was part of the ticket.)
 This file was added by mistake. It is already removed on master, so
 there's no need to remove it here. I would probably only create a merge
 conflict.

 Thanks for the very quick review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3152#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development