BIND 10 #3177: Kea6 realy agent - incorrect port number
BIND 10 Development
do-not-reply at isc.org
Sun Oct 6 20:13:48 UTC 2013
#3177: Kea6 realy agent - incorrect port number
-------------------------------------+-------------------------------------
Reporter: wlodekwencel | Owner: tomek
Type: defect | Status:
Priority: medium | reviewing
Component: dhcp6 | Milestone:
Keywords: relay | Sprint-DHCP-20131016
Sensitive: 0 | Resolution:
Sub-Project: DHCP | CVSS Scoring:
Estimated Difficulty: 0 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by stephen):
* owner: stephen => tomek
Comment:
Reviewed commit 23c944640d1b697af40582f7999b40b05b17a44a
'''src/bin/dhcp6/tests/wireshark.cc'''[[BR]]
Unless we're keeping the pcap files somewhere, a reference in a comment to
a particular pcap file is meaningless.
The setting of the local and remote address and port, and the setting of
index and interface is identical in each of the functions (albeit with a
variation of the address). This should be put in a common function (with
parameters such as address etc, passed as parameters if required).
Comments should not that the caller must delete the returned pointer.
(Alternatively, return the data via a Pkt6Ptr - it is safer.)
--
Ticket URL: <http://bind10.isc.org/ticket/3177#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list