BIND 10 #3177: Kea6 realy agent - incorrect port number

[BIND 10 Development]

#3177: Kea6 realy agent - incorrect port number
-------------------------------------+-------------------------------------
            Reporter:  wlodekwencel  |                        Owner:
                Type:  defect        |  stephen
            Priority:  medium        |                       Status:
           Component:  dhcp6         |  reviewing
            Keywords:  relay         |                    Milestone:
           Sensitive:  0             |  Sprint-DHCP-20131016
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * owner:  tomek => stephen


Comment:

 Replying to [comment:5 stephen]:
 > Reviewed commit 23c944640d1b697af40582f7999b40b05b17a44a
 >
 > '''src/bin/dhcp6/tests/wireshark.cc'''[[BR]]
 > Unless we're keeping the pcap files somewhere, a reference in a comment
 to a particular pcap file is meaningless.
 Just added the file to dhcp-val. However, since the file may contain
 sensitive info, removed the reference to it. It should be safe as the
 dhcp-val is not available publicly. Anyway, removed the filename from
 wireshark.cc.

 My plan/hope is that some day we will develop a test that will read all
 pcap files from specified directory and try to process all DHCP packets in
 them through Kea. That would be a very flexible and extensible approach.
 To add a new test case, we'd have to only add new pcap file. The pcap
 collection could be confidential and stored separately. But it's a far way
 for now.

 > The setting of the local and remote address and port, and the setting of
 index and interface is identical in each of the functions (albeit with a
 variation of the address).  This should be put in a common function (with
 parameters such as address etc, passed as parameters if required).
 Added new method.

 > Comments should not that the caller must delete the returned pointer.
 (Alternatively, return the data via a Pkt6Ptr - it is safer.)
 Done.

 Unless you have any other comments, I think this ticket is ready to merge.
 Thanks for fast review.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3177#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development