BIND 10 #3149: PD: AllocationEngine support for Prefix Delegation, pt.1

[BIND 10 Development]

#3149: PD: AllocationEngine support for Prefix Delegation, pt.1
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp6         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130918
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  0             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => tomek


Comment:

 dhcpsrv/pool.h -

 The parameter "type" for Pool's constructor describes it as the "type of
 pool", it is the type of lease.

 Same with the type_ member, it says "defines a pool type".   No, it
 "defines the lease type".

 ------------------------------------------------------------------

 alloc_engine.cc

 line 180 you need some spaces in the expression:

 currently it is:

 {{{ ipv6?LeaseType::NA:Lease::TYPE_V4; }}}

 should be:

 {{{ ipv6 ? LeaseType::NA : Lease::TYPE_V4; }}}

 I had to strain my old-man eyes to figure this out ;)

 -----------------------------------------------------------------

 Your changes seem reasonable, although the ticket text is very thin, and
 not knowing what you expected to accomplish with this ticket, it is hard
 for
 to determine if it's complete.

 Perhaps you could add a bit about what you achieved.  You should also
 mention
 that you extracted Lease, Lease4, and Lease6 into their file(s).

 -----------------------------------------------------------------

 cppcheck is clean, valgrind on unit tests is ok.


 If you agree, go ahead and merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3149#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development