BIND 10 #3149: PD: AllocationEngine support for Prefix Delegation, pt.1

[BIND 10 Development]

#3149: PD: AllocationEngine support for Prefix Delegation, pt.1
-------------------------------------+-------------------------------------
            Reporter:  tomek         |                        Owner:  tomek
                Type:  enhancement   |                       Status:
            Priority:  medium        |  closed
           Component:  dhcp6         |                    Milestone:
            Keywords:                |  Sprint-DHCP-20130918
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |  complete
Estimated Difficulty:  0             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tomek):

 * status:  reviewing => closed
 * resolution:   => complete


Comment:

 Replying to [comment:7 tmark]:
 > dhcpsrv/pool.h -
 >
 > The parameter "type" for Pool's constructor describes it as the "type of
 pool", it is the type of lease.
 > Same with the type_ member, it says "defines a pool type".   No, it
 "defines the lease type".
 Description updated.

 > alloc_engine.cc
 >
 > line 180 you need some spaces in the expression:
 >
 > currently it is:
 >
 > {{{ ipv6?LeaseType::NA:Lease::TYPE_V4; }}}
 >
 > should be:
 >
 > {{{ ipv6 ? LeaseType::NA : Lease::TYPE_V4; }}}
 >
 > I had to strain my old-man eyes to figure this out ;)
 Spaces added.

 > Your changes seem reasonable, although the ticket text is very thin, and
 > not knowing what you expected to accomplish with this ticket, it is hard
 for
 > to determine if it's complete.
 This is essentially a work split in half. You rightfully observed that
 since you plan to start work on configuration parsers, it will be
 difficult to merge your and mine changes in Pool and Subnet classes. So I
 decided to merge what I have now and then continue AllocationEngine work
 on a follow up ticket.

 > cppcheck is clean, valgrind on unit tests is ok.
 Thanks for checking.

 > If you agree, go ahead and merge.
 Agreed, updated, merged, closed.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3149#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development