BIND 10 #2274: Implement counters into Xfrin (2/3)

BIND 10 Development do-not-reply at isc.org
Mon Sep 30 08:47:36 UTC 2013


#2274: Implement counters into Xfrin (2/3)
-------------------------------------+-------------------------------------
            Reporter:  naokikambe    |                        Owner:
                Type:  enhancement   |  naokikambe
            Priority:  medium        |                       Status:
           Component:  xfrin         |  reviewing
            Keywords:                |                    Milestone:
           Sensitive:  0             |  Sprint-20131001
         Sub-Project:  DNS           |                   Resolution:
Estimated Difficulty:  5             |                 CVSS Scoring:
         Total Hours:  0             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by muks):

 * owner:  muks => naokikambe


Comment:

 Hi Kambe-san

 The branch looks good mostly. May I suggest the small change in
 `xfrin_test.py`:
 {{{
 -            msg = '%s is expected %s but actually %s' % (name, exp, act)
 +            msg = '%s: expected %s but actually got %s' % (name, exp,
 act)
 }}}

 Also, would it be better to rename `ixfr_running` and `axfr_running` to
 be `ixfr_in_progress` and `axfr_in_progress` to be consistent with the
 other key `soa_in_progress`?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2274#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list