BIND 10 #2274: Implement counters into Xfrin (2/3)

[BIND 10 Development]

#2274: Implement counters into Xfrin (2/3)
-------------------------------------+-------------------------------------
            Reporter:  naokikambe    |                        Owner:  muks
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  xfrin         |                    Milestone:
            Keywords:                |  Sprint-20131001
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  5             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by naokikambe):

 * owner:  naokikambe => muks


Comment:

 Hi Mukund san,

 Thank you for reviewing.

 > The branch looks good mostly. May I suggest the small change in
 > `xfrin_test.py`:
 > {{{
 > -            msg = '%s is expected %s but actually %s' % (name, exp,
 act)
 > +            msg = '%s: expected %s but actually got %s' % (name, exp,
 act)
 > }}}
 I've fixed:
 {{{
 6986829 [2274] editorial fix due to reviewer's suggestion
 }}}

 > Also, would it be better to rename `ixfr_running` and `axfr_running` to
 > be `ixfr_in_progress` and `axfr_in_progress` to be consistent with the
 > other key `soa_in_progress`?

 I don't think so because there seems to be name consistency with bind9's
 "rndc status". See StatisticsItems. But even if we decided to rename, I'd
 like you to do in another ticket. In such case we should rename Xfrout's
 ones too.

 Can I merge?

-- 
Ticket URL: <http://bind10.isc.org/ticket/2274#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development