BIND 10 #3221: DHCP4 should send generated NameChangeRequests to b10-dhcp-ddns

[BIND 10 Development]

#3221: DHCP4 should send generated NameChangeRequests to b10-dhcp-ddns
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  enhancement   |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:  DHCP-
            Keywords:                |  Kea0.9-alpha
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  40            |              Defect Severity:  N/A
         Total Hours:  60            |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  6 => 1
 * owner:  marcin => tmark
 * totalhours:  59 => 60


Comment:

 Reviewed commit a080f7b48a4895a5dfbee3690de6cc2881f123cd

 Replying to [comment:8 tmark]:
 > > '''src/lib/dhcp_ddns/ncr_udp.cc'''
 > > Technically, the operations on watch socket are not exception safe. In
 order words, WatchSocket class may throw an exception in
 !NameChangeUDPSender::open, doSend and sendCompletionHandler. From the
 !NameChangeSender documentation it seems ok, that the first two throw an
 exception. I am not certain if it is ok that sendCompletionHandler does,
 as a result of failure to clear the watch socket (line 314).

 I think, you didn't answer to this. Didn't want to use the word
 !''ignored!'' the comment. ;)

-- 
Ticket URL: <http://bind10.isc.org/ticket/3221#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development