BIND 10 #3221: DHCP4 should send generated NameChangeRequests to b10-dhcp-ddns

[BIND 10 Development]

#3221: DHCP4 should send generated NameChangeRequests to b10-dhcp-ddns
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  enhancement   |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:                |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea0.9-alpha
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  40            |                 CVSS Scoring:
         Total Hours:  63            |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  3
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * hours:  1 => 3
 * owner:  tmark => marcin
 * totalhours:  60 => 63


Comment:

 Replying to [comment:9 marcin]:
 > Reviewed commit a080f7b48a4895a5dfbee3690de6cc2881f123cd
 >
 > Replying to [comment:8 tmark]:
 > > > '''src/lib/dhcp_ddns/ncr_udp.cc'''
 > > > Technically, the operations on watch socket are not exception safe.
 In order words, WatchSocket class may throw an exception in
 !NameChangeUDPSender::open, doSend and sendCompletionHandler. From the
 !NameChangeSender documentation it seems ok, that the first two throw an
 exception. I am not certain if it is ok that sendCompletionHandler does,
 as a result of failure to clear the watch socket (line 314).
 >
 > I think, you didn't answer to this. Didn't want to use the word
 !''ignored!'' the comment. ;)
 >

 Sorry, I missed this.  I have improved the error handling here and added
 unit tests to ncr_udp_unittest.cc for it.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3221#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development