BIND 10 #3341: D2 should NOP updates in a given direction if no servers are defined for that direction

[BIND 10 Development]

#3341: D2 should NOP updates in a given direction if no servers are defined for
that direction
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  medium        |  reviewing
           Component:  dhcp-ddns     |                    Milestone:  DHCP-
            Keywords:                |  Kea0.9-alpha
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  16            |              Defect Severity:  N/A
         Total Hours:  7             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  6 => 1
 * owner:  marcin => tmark
 * totalhours:  6 => 7


Comment:

 Reviewed commit d1aaf04e15357b2e6198bb3e1c00a0ef5ae67ff0

 '''src/bin/d2/d2_cfg_mgr.h'''
 Don't you think that the name of these functions is a little misleading?
 Intuitevely, the updates are enabled if you explicitly enable them by
 pulling a ON/OFF trigger. Adding the server to the configuration doesn't
 have to mean that updates are enabled. For example, you could specify the
 whole configuration but for some reason don't do any updates yet (until
 you pull the trigger). So, I am wondering if this function shouldn't also
 check some configuration flag that enables updates? It is easier to
 enable/disable updates by flipping boolean value, rather than removing the
 ip address of the server - is easy to forget the IP address (or multiple
 of them) if you want to re-enable.

 Anyhow, the doxygen description should better describe the conditions for
 this function to return true or false. Currently it is in the function
 body, so as I have to go look at the actual implementation before I know
 what this function really returns.

 Nit: I wonder if these functions could be const?

 d2_update_mgr requires copyright year update.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3341#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development