BIND 10 #3341: D2 should NOP updates in a given direction if no servers are defined for that direction

[BIND 10 Development]

#3341: D2 should NOP updates in a given direction if no servers are defined for
that direction
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  defect        |  marcin
            Priority:  medium        |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:                |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea0.9-alpha
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  16            |                 CVSS Scoring:
         Total Hours:  8             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * owner:  tmark => marcin
 * totalhours:  7 => 8


Comment:

 Replying to [comment:5 marcin]:
 > Reviewed commit d1aaf04e15357b2e6198bb3e1c00a0ef5ae67ff0
 >
 > '''src/bin/d2/d2_cfg_mgr.h'''
 > Don't you think that the name of these functions is a little misleading?
 Intuitevely, the updates are enabled if you explicitly enable them by
 pulling a ON/OFF trigger. Adding the server to the configuration doesn't
 have to mean that updates are enabled. For example, you could specify the
 whole configuration but for some reason don't do any updates yet (until
 you pull the trigger). So, I am wondering if this function shouldn't also
 check some configuration flag that enables updates? It is easier to
 enable/disable updates by flipping boolean value, rather than removing the
 ip address of the server - is easy to forget the IP address (or multiple
 of them) if you want to re-enable.
 >
 > Anyhow, the doxygen description should better describe the conditions
 for this function to return true or false. Currently it is in the function
 body, so as I have to go look at the actual implementation before I know
 what this function really returns.
 >

 Actually, I named them as I did for precisely the conditions you suggest
 above.
 I thought that there may come a time when something else or in addition to
 testing the presence or absence of DDNS domains for enabling/disabling
 updates.
 I have amended the header commentary to address this, but left the names
 alone.

 Having an additiional flag is a good but would expand the effort here.
 Maybe as a follow up ticket?

 > Nit: I wonder if these functions could be const?

 In this case, not easily. I would need to add a series of const fetchers
 to
 traverse my way down to the required values. D2CfgMgr needs a non-const
 relationship to the D2CfgContext it owns and the objects under it, so I
 would
 prefer not to add this in.

 >
 > d2_update_mgr requires copyright year update.

 Am assuming you meant d2_cfg_mgr.h and cc.  Done.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3341#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development