BIND 10 #2534: support minor cases for quoted character strings

BIND 10 Development do-not-reply at isc.org
Mon Jan 27 06:33:14 UTC 2014


#2534: support minor cases for quoted character strings
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  4             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by kean):

 * owner:  kean => muks


Comment:

 I have a question about the following thunk:

 {{{
 @@ -337,7 +336,7 @@ TYPED_TEST(Rdata_TXT_LIKE_Test, toText) {

      // Check escape behavior
      const TypeParam double_quotes("Test-String\"Test-String\"");
 -    EXPECT_EQ("\"Test-String\\\"Test-String\\\"\"",
 double_quotes.toText());
 +    EXPECT_EQ("\"Test-String\" \"Test-String\"", double_quotes.toText());
      const TypeParam semicolon("Test-String\\;Test-String");
      EXPECT_EQ("\"Test-String\\;Test-String\"", semicolon.toText());
      const TypeParam backslash("Test-String\\\\Test-String");
 }}}

 Given that the input is a string with a correctly escaped string inside
 it, why do we expect  the `toText` to have converted that to a space? Was
 that changed based on mental computation of what should be returned or
 simply to accommodate a failing test? Or is it simply because the quote is
 now a separator? If that truly is the expected result then this looks
 fine. Please merge and close.

-- 
Ticket URL: <https://bind10.isc.org/ticket/2534#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list