BIND 10 #2534: support minor cases for quoted character strings
BIND 10 Development
do-not-reply at isc.org
Mon Jan 27 09:04:20 UTC 2014
#2534: support minor cases for quoted character strings
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: kean
Type: task | Status:
Priority: medium | reviewing
Component: libdns++ | Milestone:
Keywords: | Sprint-20131015
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 4 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => kean
Comment:
Hi Kean
Replying to [comment:11 kean]:
> Given that the input is a string with a correctly escaped string inside
it, why do we expect the `toText` to have converted that to a space? Was
that changed based on mental computation of what should be returned or
simply to accommodate a failing test? Or is it simply because the quote is
now a separator? If that truly is the expected result then this looks
fine. Please merge and close.
The reviewer should independently discover the reason for this and assert
if the unittest is correct. If I explain it here, we may both agree on an
incorrect behaviour. This is specially important for libdns++ code (such
as parser behaviour, RDATA syntax, etc.).
Let me ask you the same question: Given that the input is a string with a
correctly escaped string inside it, why do we expect the `toText()` method
to have converted that to a space?
If you were not able to follow the code being reviewed, I suggest
understanding the `MasterLexer` and the classes it uses (see their API doc
before browsing the code), and what this ticket is supposed to do
(`STRING` vs. `QSTRING`). In this particular case, also check `<character-
string>` from RFC 1035 and the TXT RDATA format in that RFC and how it
uses `<character-string>`s, and RFC 4408 section 3.1.3 (which also falls
into the `TXTLike` class category) which has some more details.
--
Ticket URL: <http://bind10.isc.org/ticket/2534#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list