BIND 10 #2443: skip checks in "deserialize" constructor of LabelSequence when non debug mode

BIND 10 Development do-not-reply at isc.org
Tue Jan 28 11:37:52 UTC 2014


#2443: skip checks in "deserialize" constructor of LabelSequence when non debug
mode
-------------------------------------+-------------------------------------
            Reporter:  jinmei        |                        Owner:  muks
                Type:  task          |                       Status:
            Priority:  medium        |  reviewing
           Component:  libdns++      |                    Milestone:
            Keywords:                |  Sprint-20131015
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DNS           |                 CVSS Scoring:
Estimated Difficulty:  3             |              Defect Severity:  N/A
         Total Hours:  0             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  0
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => muks


Comment:

 Reviewed commit 60a4f25645165d590b0130f810472418cdf3f5b4

 '''src/lib/dns/labelsequence.cc'''[[BR]]
 Copyright should be updated to "2012-2014".

 The [wiki:CodingGuidelines#IncludeStyle coding guidelines] state that
 angle brackes should be used in #include statements: config.h should be
 included using {{{#include <config.h>}}}.

 '''src/lib/dns/tests/labelsequence_unittest.cc'''[[BR]]
 Copyright should be updated to "2012-2014".

 Need to include 'config.h' else the badDeserialize test will not get
 executed when BIND 10 is built with --enable-debug.

 ----
 The changes listed above were trivial, so I've updated the files and
 pushed the results.  If you agree with them, please merge.

 I agree that no !ChangeLog is required.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2443#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list