BIND 10 #2443: skip checks in "deserialize" constructor of LabelSequence when non debug mode
BIND 10 Development
do-not-reply at isc.org
Wed Jan 29 13:32:16 UTC 2014
#2443: skip checks in "deserialize" constructor of LabelSequence when non debug
mode
-------------------------------------+-------------------------------------
Reporter: jinmei | Owner: muks
Type: task | Status:
Priority: medium | reviewing
Component: libdns++ | Milestone:
Keywords: | bind10-1.2-release-freeze
Sensitive: 0 | Resolution:
Sub-Project: DNS | CVSS Scoring:
Estimated Difficulty: 3 | Defect Severity: N/A
Total Hours: 0 | Feature Depending on Ticket:
| Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Comment (by muks):
Good catch on the `labelsequence_unittest.cc` update. I don't know how the
unittest got missed (as IIRC I checked with debugging enabled and
disabled).
Regarding the include style, I don't know what is better. Though we picked
the angled brackets, a `config.h` distributed by some other package in the
system directories will take precedence over the local `config.h` (though
the standards attach completely different meanings to `""` vs `<>`). I
don't have a preference (basically because it's so ambiguous) and this
change in the branch is fine.
--
Ticket URL: <https://bind10.isc.org/ticket/2443#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list