BIND 10 #3362: d2::NameRemoveTransaction should check for NXRRSET not NXDOMAIN

[BIND 10 Development]

#3362: d2::NameRemoveTransaction should check for NXRRSET not NXDOMAIN
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:  tmark
                Type:  defect        |                       Status:
            Priority:  high          |  reviewing
           Component:  dhcp-ddns     |                    Milestone:  DHCP-
            Keywords:                |  Kea0.9
           Sensitive:  0             |                   Resolution:
         Sub-Project:  DHCP          |                 CVSS Scoring:
Estimated Difficulty:  4             |              Defect Severity:  N/A
         Total Hours:  1             |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  1
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by marcin):

 * hours:  2 => 1
 * owner:  marcin => tmark
 * totalhours:  0 => 1


Comment:

 Reviewed commit 72d508acc50c642e4958937532b3728bdccf5a75

 It may be useful to add some reference to the RFC2136 (Section 3.2.3?) in
 the code to explain why NXRRSET is a success. I know that there is the
 comment saying that this signal means !''there are no RRs for the FQDN!''
 but there is no reference to appropriate text.

 Regarding the !ChangeLog. The word !''server!'' is a little confusing:
 {{{
 This corrects a defect in which the server would incorrectly fail a...
 }}}
 You mean: DHCP server, not a DNS server? DNS server doesn't make sense. Is
 b10-dhcp-ddns a server? Perhaps use !''b10-dhcp-ddns!'' instead of
 !''server!''? Or maybe !''DDNS module!''?

 It would be interesting to see if other DNS servers would return the same
 code. Did we consider testing DDNS against any other DNS server, e.g.
 dnsmasq? It is not the task for this ticket obviously, just an idea for
 testing.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3362#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development