BIND 10 #3362: d2::NameRemoveTransaction should check for NXRRSET not NXDOMAIN

[BIND 10 Development]

#3362: d2::NameRemoveTransaction should check for NXRRSET not NXDOMAIN
-------------------------------------+-------------------------------------
            Reporter:  tmark         |                        Owner:
                Type:  defect        |  marcin
            Priority:  high          |                       Status:
           Component:  dhcp-ddns     |  reviewing
            Keywords:                |                    Milestone:  DHCP-
           Sensitive:  0             |  Kea0.9
         Sub-Project:  DHCP          |                   Resolution:
Estimated Difficulty:  4             |                 CVSS Scoring:
         Total Hours:  2             |              Defect Severity:  N/A
                                     |  Feature Depending on Ticket:
                                     |          Add Hours to Ticket:  .5
                                     |                    Internal?:  0
-------------------------------------+-------------------------------------
Changes (by tmark):

 * hours:  1 => .5
 * owner:  tmark => marcin
 * totalhours:  1 => 2


Comment:

 Replying to [comment:4 marcin]:
 > Reviewed commit 72d508acc50c642e4958937532b3728bdccf5a75
 >
 > It may be useful to add some reference to the RFC2136 (Section 3.2.3?)
 in the code to explain why NXRRSET is a success. I know that there is the
 comment saying that this signal means !''there are no RRs for the FQDN!''
 but there is no reference to appropriate text.


 I added commentary citing RFCs and such.

 >
 > Regarding the !ChangeLog. The word !''server!'' is a little confusing:
 > {{{
 > This corrects a defect in which the server would incorrectly fail a...
 > }}}
 > You mean: DHCP server, not a DNS server? DNS server doesn't make sense.
 Is b10-dhcp-ddns a server? Perhaps use !''b10-dhcp-ddns!'' instead of
 !''server!''? Or maybe !''DDNS module!''?
 >

 Yes, it should use "b10-dhcp-ddns" instead.

 {{{
 7xx.    [bug]      tmark
     b10-dhcp-ddns now treats a DNS server response code of NXRRSET as a
     successful outcome when processing a request to remove DNS data.  This
     corrects a defect in which b10-dhcp-ddns would incorrectly fail a
 request
     to remove DNS data when the DNS server's response was NXRRSET.
     (Trac #3362, git TBD)
 }}}


 > It would be interesting to see if other DNS servers would return the
 same code. Did we consider testing DDNS against any other DNS server, e.g.
 dnsmasq? It is not the task for this ticket obviously, just an idea for
 testing.

 I have thought about this, and on a broader scale we should test D2 with
 other DNSs, but not
 under the effort of this ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/3362#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development